remove ENABLE_ECL_(IN|OUT)PUT options #5039
Conversation
akva2
added
the
manual:irrelevant
|
jenkins build this opm-grid=998 opm-simulators=6896 opm-upscaling=436 please |
1 similar comment
|
jenkins build this opm-grid=998 opm-simulators=6896 opm-upscaling=436 please |
|
jenkins build this opm-grid=998 opm-simulators=6896 opm-upscaling=436 please |
|
jenkins build this opm-grid=998 opm-simulators=6896 opm-upscaling=436 please |
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
I like it and the code changes here are trivial.
The rationale against this change that was initially raised in #1127/#1129 does not apply anymore in my opinion since the Dune build system is rather different today than at that time.
I'd really like to see this go in now, but I'll hold off on merging until other maintainers have had the opportunity to comment.
|
jenkins build this opm-grid=998 opm-simulators=6896 opm-upscaling=436 please |
|
jenkins build this opm-grid=998 opm-simulators=6896 opm-upscaling=436 please |
|
jenkins build this opm-grid=998 opm-simulators=6896 opm-upscaling=436 please |
1 similar comment
|
jenkins build this opm-grid=998 opm-simulators=6896 opm-upscaling=436 please |
having options to disable the entire point of the library is extremely painful to maintain and kinda fruitless.
|
jenkins build this opm-grid=998 opm-simulators=6896 opm-upscaling=436 please |
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Thanks a lot for taking on this herculean task. I'll merge into master.
2 participants
having options to disable the entire point of the library is extremely painful to maintain and kinda fruitless.
I'm going to try this again. These options are painful to maintain (they are very broken again in opm-grid and have been for a while since I last fixed them). The only rationale for this is that you want to use opm-grid without ECL support.
To this end, I have instead added an option in opm-grid to build it without using opm-common data structures.
You only have to configure opm-common, not build it, and then you can build opm-grid without opm-common support, voiding the argument that 'building opm-common takes a long while'. This is necessary due to the shared build system.
Closes #1127.
Closes #1129.